Re: [PATCH 1/3] Update create-version.sh to use common/version.h

[Tom Tromey <tom at tromey dot com>]

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> An easy way to fix this would be to add -I$(srcsim) to the include
Simon> paths in sim/common/Make-common.in.  We could actually think of giving
Simon> the same treatment of removing -I../common and -I$(srccom) to sim than
Simon> what you did to GDB.

I don't really know much about the sim, so I don't really have an
opinion on whether that makes sense there.

For the immediate problem, I think it's usually not good to have these
hidden cross-directory dependencies.  This one seems particularly bad
because it's somewhat uncommon to even build the sim.

How about just copying create-version.sh to sim/common and having it use
the old #include "version.h"?  Then the two scripts can evolve in their
own ways as needed, without worrying.

Tom