This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH RESEND] gdb: xtensa: fix register counters for xtensa-linux
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: Woody LaRue <larue at cadence dot com>
- Date: Sun, 13 Jan 2019 05:56:10 +0000
- Subject: Re: [PATCH RESEND] gdb: xtensa: fix register counters for xtensa-linux
- References: <20190113014248.28071-1-jcmvbkbc@gmail.com>
On 2019-01-12 8:42 p.m., Max Filippov wrote:
> Commit 37d9e0623102 ("gdb: xtensa: handle privileged registers") changed
> how the tdep->num_regs and tdep->num_pseudo_regs are calculated, but
> didn't update these numbers in the gdbarch for the xtensa-linux target.
> As a result xtensa-linux-gdb behaves as xtensa-elf-gdb and cannot
> communicate with the linux gdbserver.
> Fix tdep->num_pseudo_regs calculation and call set_gdbarch_num_regs and
> set_gdbarch_num_pseudo_regs in xtensa_linux_init_abi.
>
> gdb/
> 2018-11-16 Max Filippov <jcmvbkbc@gmail.com>
>
> * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
> tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
> set_gdbarch_num_pseudo_regs.
> ---
> gdb/xtensa-linux-tdep.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/xtensa-linux-tdep.c b/gdb/xtensa-linux-tdep.c
> index 1764b953a00b..796143c6699b 100644
> --- a/gdb/xtensa-linux-tdep.c
> +++ b/gdb/xtensa-linux-tdep.c
> @@ -101,7 +101,13 @@ xtensa_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
>
> if (tdep->num_nopriv_regs < tdep->num_regs)
> - tdep->num_regs = tdep->num_nopriv_regs;
> + {
> + tdep->num_pseudo_regs += tdep->num_regs - tdep->num_nopriv_regs;
> + tdep->num_regs = tdep->num_nopriv_regs;
> +
> + set_gdbarch_num_regs (gdbarch, tdep->num_regs);
> + set_gdbarch_num_pseudo_regs (gdbarch, tdep->num_pseudo_regs);
> + }
>
> linux_init_abi (info, gdbarch);
>
>
Hi Max.
I am just a bit puzzled by the num_pseudo_regs computation (especially the +=).
Can you explain it quickly?
Thanks,
Simon