This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/5] gdb/23712: Introduce multidictionary's
- From: Keith Seitz <keiths at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 10 Jan 2019 14:10:32 -0800
- Subject: Re: [PATCH 1/5] gdb/23712: Introduce multidictionary's
- References: <20181109022847.32049-1-keiths@redhat.com> <87lg4p4d92.fsf@tromey.com> <36e34a33-55bb-07aa-13f4-70b83f5026bf@redhat.com> <87tvirvwou.fsf@tromey.com>
On 1/2/19 8:41 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> [... size cost of the change...]
> Keith> This sounded incredibly wasteful to me when I wrote this patch.
>
> I have been thinking about this patch over the break, and I don't have
> any more objections. It fixes a serious bug and is not overly
> expensive; and furthermore I think it isn't any more complicated than
> the alternative. So, this is ok.
>
I know this hasn't been an easy process for anyone, including users, and it
has obviously been a more-than-expected agonizing review process for you. So
a big thank you to everyone affected by this bug for their patience and
perseverance.
Pursuant to previous comments, I've updated the ChangeLog entries
to also mention symtab/23010 and changed the final patch (the test)
to use gdb_spawn_with_cmdline_opts. I've verified that the test
fails before this patch and passes afterwards. I believe that was all
that was requested.
I've now pushed this series. Let's hope that's the last we see of this
for a little while, at least! ;-)
Thank you again!
Keith