Re: [PATCH v2] gdb: Remove support for old mangling schemes

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2019-01-09 10:39, Eli Zaretskii wrote:
> > From: Simon Marchi <simon.marchi@polymtl.ca>
> > Cc: Simon Marchi <simon.marchi@ericsson.com>
> > Date: Tue,  8 Jan 2019 23:50:32 -0500
> >
> > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> > index 4bca933195c9..ffc702937b7a 100644
> > --- a/gdb/doc/gdb.texinfo
> > +++ b/gdb/doc/gdb.texinfo
> > @@ -10703,31 +10703,9 @@ or demangled form.
> >  @cindex symbol decoding style, C@t{++}
> >  @kindex set demangle-style
> >  @item set demangle-style @var{style}
> > -Choose among several encoding schemes used by different compilers to
> > -represent C@t{++} names.  The choices for @var{style} are currently:
> > -
> > -@table @code
> > -@item auto
> > -Allow @value{GDBN} to choose a decoding style by inspecting your 
> > program.
> > -This is the default.
>
> Are we removing 'auto' as well?  If not, why do we want to un-document
> it?

I decided to remove the list of possible values and refer to the 
in-process help, this way we don't have to keep it up to date (as you 
might notice, the list was incomplete).  But since the value "auto" is 
special, I agree we should mention it.  Is it fine if I add this 
sentence?

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index ffc702937b7..4a00834d0bf 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -10705,7 +10705,8 @@ or demangled form.
 @item set demangle-style @var{style}
 Choose among several encoding schemes used by different compilers to 
represent
 C@t{++} names.  If you omit @var{style}, you will see a list of 
possible
-formats.
+formats.  The default value is @var{auto}, which lets @value{GDBN} 
choose a
+decoding style by inspecting your program.

 @item show demangle-style
 Display the encoding style currently in use for decoding C@t{++} 
symbols.

Simon