This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/4] gdb: Move declarations from symtab.h to source.h

From: Tom Tromey <tom at tromey dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org, Tom Tromey <tom at tromey dot com>
Date: Mon, 07 Jan 2019 22:20:36 -0700
Subject: Re: [PATCH 3/4] gdb: Move declarations from symtab.h to source.h
References: <cover.1546860547.git.andrew.burgess@embecosm.com> <cover.1546860547.git.andrew.burgess@embecosm.com> <9be27aa313ee18a120db4ae6e5068fede3e6a5da.1546860547.git.andrew.burgess@embecosm.com>

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Declarations for functions in source.c are split between source.h and
Andrew> symtab.h.  This commit moves the small number that are in symtab.h
Andrew> into source.h.  There's just one file that needs to add an include of
Andrew> source.h in order to build.

Andrew> I've moved the function header comments from source.c to source.h
Andrew> inline with the recommended GDB style.

Thanks.  This is a nice cleanup.  Please check it in.

Tom

References:
- [PATCH 0/4] Fix some regressions caused by source highlighting patch
  - From: Andrew Burgess
- [PATCH 3/4] gdb: Move declarations from symtab.h to source.h
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]