This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/3] Use std::vector in type stacks

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sun, 06 Jan 2019 09:40:16 -0700
Subject: Re: [PATCH 1/3] Use std::vector in type stacks
References: <20190105204112.26849-1-tom@tromey.com> <20190105204112.26849-2-tom@tromey.com> <f590f22d0d4b129b8f7bb2a5bcd2c90b@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> The = should be on the next line.

[...]

>> @@ -3276,6 +3287,9 @@ c_parse (struct parser_state *par_state)
>> gdb_assert (par_state != NULL);
>> pstate = par_state;
>> 
>> +  c_parse_state cstate;
>> +  scoped_restore cstate_resotre = make_scoped_restore (&cpstate,
>> &cstate);

Simon> "resotre"

Simon> Otherwise, LGTM.

Thanks for the review.  I'm checking it in with these fixes.

Tom

References:
- [PATCH 0/3] Remove cleanups from c-exp.y
  - From: Tom Tromey
- [PATCH 1/3] Use std::vector in type stacks
  - From: Tom Tromey
- Re: [PATCH 1/3] Use std::vector in type stacks
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]