This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/12] gdb/cris: Use default gdbarch methods where possible


> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Thu, 27 Dec 2018 14:08:30 +0000

> Make use of the default gdbarch methods for gdbarch_dummy_id,
> gdbarch_unwind_pc, and gdbarch_unwind_sp where possible.
> 
> I have not tested this change but, by inspecting the code, I believe
> the default methods are equivalent to the code being deleted.
> 
> gdb/ChangeLog:
> 
> 	* gdb/cris-tdep.c (cris_dummy_id): Delete.
> 	(cris_unwind_pc): Delete.
> 	(cris_unwind_sp): Delete.
> 	(cris_gdbarch_init): Don't register deleted functions with
> 	gdbarch.

LGTM, thanks.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]