This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 3/5] Simplify gdbpy_stop_recording
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Thu, 27 Dec 2018 12:26:35 -0700
- Subject: [PATCH 3/5] Simplify gdbpy_stop_recording
- References: <20181227192637.17862-1-tom@tromey.com>
This simplifies gdbpy_stop_recording, by having it use Py_RETURN_NONE
rather than writing it out manually, and by usin the idiomatic
GDB_PY_HANDLE_EXCEPTION.
2018-12-27 Tom Tromey <tom@tromey.com>
* python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
---
gdb/ChangeLog | 4 ++++
gdb/python/py-record.c | 8 ++------
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdb/python/py-record.c b/gdb/python/py-record.c
index b203786473..4b5de40f3e 100644
--- a/gdb/python/py-record.c
+++ b/gdb/python/py-record.c
@@ -638,19 +638,15 @@ gdbpy_current_recording (PyObject *self, PyObject *args)
PyObject *
gdbpy_stop_recording (PyObject *self, PyObject *args)
{
- PyObject *ret = NULL;
-
TRY
{
record_stop (0);
- ret = Py_None;
- Py_INCREF (Py_None);
}
CATCH (except, RETURN_MASK_ALL)
{
- gdbpy_convert_exception (except);
+ GDB_PY_HANDLE_EXCEPTION (except);
}
END_CATCH
- return ret;
+ Py_RETURN_NONE;
}
--
2.17.2