This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/3] Fix leak in mdebugread.c

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 14 Dec 2018 17:28:48 -0500
Subject: Re: [PATCH 1/3] Fix leak in mdebugread.c
References: <20181214191242.21560-1-palves@redhat.com> <20181214191242.21560-2-palves@redhat.com>

On 2018-12-14 14:12, Pedro Alves wrote:

Coverity points out that all the "continue;" statements in the switch
case in parse_partial_symbols leak STABSTRING.  This is because we
only release STABSTRING at the end of the scope, with:

     	     	  if (stabstring
		    && stabstring != debug_info->ss + fh->issBase + sh.iss)
		  xfree (stabstring);

but that bit of code is skipped if a case in the switch statement ends
with "continue".

Fix this by using gdb::unique_xmalloc_ptr to manage the heap-allocated
version of 'stabsstring'.


This LGTM, AFAICT.

I don't know how to test this.


Go back in time?

Simon

References:
- [PATCH 0/3] Fix a few leaks found by Coverity
  - From: Pedro Alves
- [PATCH 1/3] Fix leak in mdebugread.c
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]