This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).

From: Tom Tromey <tom at tromey dot com>
To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 29 Nov 2018 16:29:03 -0700
Subject: Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).
References: <20181124115237.8943-1-philippe.waroquiers@skynet.be> <87ftvjbvmc.fsf@tromey.com> <1543533240.4149.9.camel@skynet.be>

>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:

Philippe> Note that after having run all GDB tests under valgrind, I still
Philippe> see some 4K leaks in open_source_file appearing (I suspect)
Philippe> when GDB reloads an executable that has changed.

What are the leaks?  I wonder if the "fullname"s in the psymtabs aren't
being freed.

I have been wondering lately if this field should be pulled out into
some separate hash table.  This would save a little memory if there are
file names, which seems likely.

Tom

Follow-Ups:
- Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).
  - From: Philippe Waroquiers

References:
- [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).
  - From: Philippe Waroquiers
- Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).
  - From: Tom Tromey
- Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).
  - From: Philippe Waroquiers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]