This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] Fix regression 'info variables' does not show minimal symbols.
- From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 10 Nov 2018 13:36:18 +0100
- Subject: Re: [RFA 1/2] Fix regression 'info variables' does not show minimal symbols.
- References: <20181030212336.10359-1-philippe.waroquiers@skynet.be> <20181030212336.10359-2-philippe.waroquiers@skynet.be> <1d60a4ce-7688-331d-263f-671513e0753f@ericsson.com>
On Fri, 2018-11-09 at 20:41 +0000, Simon Marchi wrote:
> I don't feel qualified to approve, since I haven't followed the original story
> and this code is rather tortuous.
Yes, the code there is not very trivial, and I have added the wrong condition:
if (kind != VARIABLES_DOMAIN>
&& !treg.has_value () /* minimal symbol has never a type ???? */
in the very first version of the patch, and I cannot make any sense of it
now.
With the fix in this patch, for this part of the code, we basically go back
to the GDB 8.2 logic, with just the addition of
&& !treg.has_value ())
to 'enter' in the minsym case.
This should ensure that at least there is no regression compared to 8.2,
when not using the new type matching argument, as there was no treg in 8.2.
Pedro reviewed this patch series, so might shed some more lights on
this fix.
> I just have a small formatting nit.
which I have fixed, waiting for Pedro's feedback.
Thanks for looking at the patch
Philippe