This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove a VEC from remote.c

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: Tom Tromey <tom at tromey dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
Date: Fri, 09 Nov 2018 16:05:45 -0700
Subject: Re: [PATCH] Remove a VEC from remote.c
References: <20181104160649.8292-1-tom@tromey.com> <f76e8c80-9a3a-ae13-4f8a-3fedd48755e8@ericsson.com>

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

>> +  data->guesses.push_back (new_guess);

Simon> I always prefer having a constructor and using
Simon> data-> guesses.emplace_back (bytes, tdesc);
Simon> since it makes it impossible to have uninitialized fields by mistake.

I'm checking it in with this change.

Tom

References:
- [PATCH] Remove a VEC from remote.c
  - From: Tom Tromey
- Re: [PATCH] Remove a VEC from remote.c
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]