This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Note that PT_GETREGS supplies SSTATUS for FreeBSD/riscv.
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: John Baldwin <jhb at FreeBSD dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 5 Nov 2018 22:34:54 +0000
- Subject: Re: [PATCH] Note that PT_GETREGS supplies SSTATUS for FreeBSD/riscv.
- References: <20181105215723.23683-1-jhb@FreeBSD.org>
* John Baldwin <jhb@FreeBSD.org> [2018-11-05 13:57:23 -0800]:
> This permits reading the value of the SSTATUS CSR returned by ptrace()
> for live FreeBSD/riscv processes.
>
> * riscv-fbsd-nat.c (getregs_supplies): Return true for
> RISCV_CSR_SSTATUS_REGNUM.
Looks good. Thanks,
Andrew
> ---
> gdb/ChangeLog | 5 +++++
> gdb/riscv-fbsd-nat.c | 3 ++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index bc77fe85c7..b78d58625e 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2018-11-05 John Baldwin <jhb@FreeBSD.org>
> +
> + * riscv-fbsd-nat.c (getregs_supplies): Return true for
> + RISCV_CSR_SSTATUS_REGNUM.
> +
> 2018-11-04 Tom Tromey <tom@tromey.com>
>
> * varobj.c (install_default_visualizer): Update.
> diff --git a/gdb/riscv-fbsd-nat.c b/gdb/riscv-fbsd-nat.c
> index ad4ea1e0ad..e66f491284 100644
> --- a/gdb/riscv-fbsd-nat.c
> +++ b/gdb/riscv-fbsd-nat.c
> @@ -42,7 +42,8 @@ static riscv_fbsd_nat_target the_riscv_fbsd_nat_target;
> static bool
> getregs_supplies (struct gdbarch *gdbarch, int regnum)
> {
> - return (regnum >= RISCV_RA_REGNUM && regnum <= RISCV_PC_REGNUM);
> + return ((regnum >= RISCV_RA_REGNUM && regnum <= RISCV_PC_REGNUM)
> + || regnum == RISCV_CSR_SSTATUS_REGNUM);
> }
>
> /* Determine if PT_GETFPREGS fetches REGNUM. */
> --
> 2.18.0
>