This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] RISC-V: Don't allow unaligned breakpoints.

From: Jim Wilson <jimw at sifive dot com>
To: John Baldwin <jhb at freebsd dot org>
Cc: gdb-patches at sourceware dot org
Date: Thu, 1 Nov 2018 16:36:50 -0700
Subject: Re: [PATCH] RISC-V: Don't allow unaligned breakpoints.
References: <20181101214139.27196-1-jimw@sifive.com> <e4fa69a6-aa80-b7ad-7ec6-62ec80888720@FreeBSD.org>

On Thu, Nov 1, 2018 at 3:05 PM John Baldwin <jhb@freebsd.org> wrote:
> This looks good to me.  Not sure if you want to explicitly add something to
> the comment that an unaligned PC is only valid if C is supported, so we
> know C.EBREAK is safe to use with an unaligned PC?

That seemed obvious to me, but yes it is probably better to spell it
out in a comment.  I'll add that to the patch.

Jim

References:
- [PATCH] RISC-V: Don't allow unaligned breakpoints.
  - From: Jim Wilson
- Re: [PATCH] RISC-V: Don't allow unaligned breakpoints.
  - From: John Baldwin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]