This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: Tom Tromey <tom at tromey dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
Date: Wed, 31 Oct 2018 09:03:50 -0600
Subject: Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
References: <20181018223100.20693-1-tom@tromey.com> <20181018223100.20693-4-tom@tromey.com> <e334bc95-f650-c4c1-1817-7256636eb2f1@ericsson.com> <6a239617-b748-0a9f-185b-2adcb19c50bc@ericsson.com> <87efc7nohb.fsf@tromey.com> <f062185a-be33-7966-eced-5e547c373966@ericsson.com>

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

>> It would be normal to look at TMPDIR on unix systems.

Simon> Ah, indeed.  How is it with this little fixup on top of the patch?

Seems reasonable, thanks!

Simon> +  char *tmp = getenv ("TMPDIR");

A tiny nit: you can use const char * here.

Tom

References:
- [PATCH v2 0/6] A different approach to startup-with-shell on macOS
  - From: Tom Tromey
- [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
  - From: Tom Tromey
- Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
  - From: Simon Marchi
- Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
  - From: Simon Marchi
- Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
  - From: Tom Tromey
- Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]