This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: pedromfc at linux dot ibm dot com (Pedro Franco de Carvalho)
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 31 Oct 2018 14:14:44 +0100 (CET)
- Subject: Re: Regression on old kernels (Re: [PATCH v5 00/12] GDB support for more powerpc registers on linux)
Pedro Franco de Carvalho wrote:
> Ulrich Weigand <uweigand@de.ibm.com> writes:
>
> >> gdb/gdbserver/ChangeLog:
> >> YYYY-MM-DD Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>
> >>
> >> * linux-ppc-low.c: Include nat/linux-ptrace.h.
> >
> > This is probably unnecessary; linux-ppc-low.c already includes
> > linux-low.h which in turn includes nat/linux-ptrace.h
>
> Ah I didn't notice that. However, the wiki says I shouldn't use
> definitions by indirect inclusion, and linux-low.c itself includes both
> headers. Should I still remove this?
Well, it doesn't really matter. If you want to add the include,
that's fine with me as well.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com