This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix thinko on common/offset-type.h (compare 'lhs' against 'rhs')
On 10/26/2018 07:23 PM, Simon Marchi wrote:
> On 2018-10-26 12:29, Sergio Durigan Junior wrote:
>>> Therefore, I think we could just remove the relational operator definitions
>>> entirely.
>>
>> OK, I'll go with that, then. I'll submit a patch for that soon (have
>> some errands to run right now).
>
> We just need confirmation from Pedro that this is ok and we're not missing anything important here.
I don't recall why I added that. Probably just assumed blindly
that it was needed.
I think the functions aren't called because they are templates, and
thus the built-in (non-template) versions take preference. If you
make them non-templates, then they should be called. But, the
built-ins are fine, so yeah, we can just remove the
custom definitions.
Thanks,
Pedro Alves