This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Fwd: Re: [PATCH 0/2] Return gdbpy_ref in a couple more places
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 25 Oct 2018 13:53:28 +0100
- Subject: Fwd: Re: [PATCH 0/2] Return gdbpy_ref in a couple more places
- References: <073ea992-5ba8-596c-3049-d6d7179df8bd@redhat.com>
Whoops, I didn't reply to the list in this email. Forwarding.
Cheers
Phil
-------- Forwarded Message --------
Subject: Re: [PATCH 0/2] Return gdbpy_ref in a couple more places
Date: Thu, 25 Oct 2018 13:46:26 +0100
From: Phil Muldoon <pmuldoon@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
On 24/10/2018 20:12, Andrew Burgess wrote:
> I spotted a couple of places where a gdbpy_ref was released in one
> function only to be recreated again later.
>
> Thanks,
> Andrew
>
> Andrew Burgess (2):
> gdb/python: Make a function return gdbpy_ref<>
> gdb/python: Make a function return gdbpy_ref<>
>
> gdb/ChangeLog | 12 ++++++++++++
> gdb/python/py-cmd.c | 16 ++++++++--------
> gdb/python/py-function.c | 9 ++++++---
> 3 files changed, 26 insertions(+), 11 deletions(-)
>
This patch also looks good to me (with Simon's qualifying comment
instruction).
Cheers
Phil