Re: [PATCH 2/3] Pass inferior to terminal_inferior

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2018-10-22 16:54, Pedro Alves wrote:
> On 10/16/2018 04:38 AM, Simon Marchi wrote:
>
> > diff --git a/gdb/target.h b/gdb/target.h
> > index c37405205a0a..310c942bbe5b 100644
> > --- a/gdb/target.h
> > +++ b/gdb/target.h
> > @@ -581,7 +581,14 @@ struct target_ops
> >        TARGET_DEFAULT_RETURN (false);
> >      virtual void terminal_init ()
> >        TARGET_DEFAULT_IGNORE ();
> > -    virtual void terminal_inferior ()
> > +
> > +    /* If INF shares a terminal with GDB, restore the saved terminal 
> > settings
> > +       associated to INF (see terminal_save_inferior) to the current
> > +       terminal.  In a scenario where multiple inferiors share GDB's 
> > terminal,
> > +       don't apply the settings of another inferior's settings are 
> > currently
>
> s/of/if/.

Fixed.

> > +       applied (in other words, the first inferior's settings win and 
> > should not
> > +       be overwritten).  */
>
> > +    virtual void terminal_inferior (inferior *inf)
> >        TARGET_DEFAULT_IGNORE ();
> >
> >      /* If INF shares a terminal with GDB, save the current terminal 
> > settings
>
> OK.

Thanks.

Simon