This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/6] Eliminate make_symbol_overload_list-related globals & cleanup
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 17 Oct 2018 17:25:16 +0000
- Subject: Re: [PATCH 3/6] Eliminate make_symbol_overload_list-related globals & cleanup
- References: <20181015151115.6356-1-palves@redhat.com> <20181015151115.6356-4-palves@redhat.com>
On 2018-10-15 11:11 a.m., Pedro Alves wrote:
> This gets rid of a few globals and a cleanup.
>
> make_symbol_overload_list & friends currently maintain a global
> open-coded vector. Reimplement that with a std::vector, trickled down
> through the functions. Rename a few functions from "make_" to "add_"
> for clarity.
LGTM, my only comment would be to avoid non-const passing by reference, as in
the previous patch.
Simon