This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Fix resource leak found by Coverity

From: Tom Tromey <tom at tromey dot com>
To: Gary Benson <gbenson at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 10 Oct 2018 10:01:09 -0600
Subject: Re: [PATCH 2/2] Fix resource leak found by Coverity
References: <1539176277-4500-1-git-send-email-gbenson@redhat.com> <1539176277-4500-3-git-send-email-gbenson@redhat.com>

>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:

Gary> This commit fixes a resource leak found by Coverity, where interp's
Gary> constructor allocated memory for m_name that interp's destructor did
Gary> not free.

Elsewhere Pedro asked for a different patch subject, so I think that
would apply here as well.

Gary> 	* interps.h (interp::m_name): Make private and mutable.
Gary> 	* interps.c (interp::~interp): Free m_name.

This is ok.

Tom

References:
- [PATCH 0/2] Fix resource leaks found by Coverity
  - From: Gary Benson
- [PATCH 2/2] Fix resource leak found by Coverity
  - From: Gary Benson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]