This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Add missing va_end found by Coverity
- From: Gary Benson <gbenson at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 10 Oct 2018 10:32:41 +0100
- Subject: [PATCH] Add missing va_end found by Coverity
Hi all,
This commit adds a missing va_end found by Coverity.
Built and regtested on RHEL 7.5 x86_64.
Ok to commit?
Thanks,
Gary
--
gdb/ChangeLog:
* remote.c (remote_target::remote_send_printf): Add
missing va_end found by Coverity.
---
gdb/ChangeLog | 5 +++++
gdb/remote.c | 6 +++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 724f41c..c53553a 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -8938,7 +8938,11 @@ remote_target::remote_send_printf (const char *format, ...)
va_start (ap, format);
rs->buf[0] = '\0';
- if (vsnprintf (rs->buf, max_size, format, ap) >= max_size)
+ int size = vsnprintf (rs->buf, max_size, format, ap);
+
+ va_end (ap);
+
+ if (size >= max_size)
internal_error (__FILE__, __LINE__, _("Too long remote packet."));
if (putpkt (rs->buf) < 0)
--
1.8.3.1