This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/8] Add -Wshadow=local
Hi Tom,
>>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>
> Joel> Coming late to the party, but fwiw, I think it's a good idea too.
> Joel> Thanks for doing this, Tom.
>
> I've fixed the problem Simon pointed out, and I went through the patches
> again. I think they are ok but I guess I would.
>
> I'm going to check this in now.
> Let me know if you encounter any problems.
this patch series broke the Solaris builds:
../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’:
../../binutils-gdb/gdb/sol-thread.c:443:14: error: declaration of ‘save_ptid’ shadows a previous local [-Werror=shadow=compatible-local]
ptid_t save_ptid = ptid;
^~~~~~~~~
../../binutils-gdb/gdb/sol-thread.c:432:10: note: shadowed declaration is here
ptid_t save_ptid;
^~~~~~~~~
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University