This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 02/10] Change dwarf2_frame_state_reg_info::reg to be std::vector

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Wed, 3 Oct 2018 18:27:57 +0100
Subject: Re: [PATCH v2 02/10] Change dwarf2_frame_state_reg_info::reg to be std::vector
References: <20181002044420.17628-1-tom@tromey.com> <20181002044420.17628-3-tom@tromey.com>

On 10/02/2018 05:44 AM, Tom Tromey wrote:
> This changes dwarf2_frame_state_reg_info::reg to be a std::vector.
> This avoids undefined behavior in the copy constructor when the
> original object does not have any registers.

I don't have anything to say against the patch, I think it's a nice
cleanup regardless, but could you expand this log a little to point
out exactly what is triggering the undefined behavior.  I guess we're
passing NULL to the memcpy?  LGTM otherwise.

Thanks,
Pedro Alves

Follow-Ups:
- Re: [PATCH v2 02/10] Change dwarf2_frame_state_reg_info::reg to be std::vector
  - From: Tom Tromey

References:
- [PATCH v2 00/10] Undefined Behavior Sanitizer, this time with docs
  - From: Tom Tromey
- [PATCH v2 02/10] Change dwarf2_frame_state_reg_info::reg to be std::vector
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]