This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 7/8] Shadowing fix in gdbscm_frame_read_var
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Sat, 22 Sep 2018 22:08:13 -0600
- Subject: [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var
- References: <20180923040814.27941-1-tom@tromey.com>
-Wshadow=local pointed out that the shadowing in gdbscm_frame_read_var
means that the ultimate call to read_var_value will always be passed
block==NULL. The fix is to remove the outer declaration.
gdb/ChangeLog
2018-09-22 Tom Tromey <tom@tromey.com>
* guile/scm-frame.c (gdbscm_frame_read_var): Remove inner
declaration of "block".
---
gdb/ChangeLog | 5 +++++
gdb/guile/scm-frame.c | 1 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c
index 3d27907e19..5a056de332 100644
--- a/gdb/guile/scm-frame.c
+++ b/gdb/guile/scm-frame.c
@@ -878,7 +878,6 @@ gdbscm_frame_read_var (SCM self, SCM symbol_scm, SCM rest)
}
else if (scm_is_string (symbol_scm))
{
- const struct block *block = NULL;
struct gdb_exception except = exception_none;
if (! SCM_UNBNDP (block_scm))
--
2.17.1