This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode

From: Joel Brobecker <brobecker at adacore dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 17 Sep 2018 14:21:35 -0700
Subject: Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode
References: <20180916184502.19617-1-tom@tromey.com> <20180916184502.19617-3-tom@tromey.com> <20180917181905.GD19172@adacore.com> <87va74ugpf.fsf@tromey.com> <87r2hrnbox.fsf@tromey.com>

> >>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
> Joel> Are we missing a '$' before tentative_python_cflags in the string,
> Joel> by any chance?
> 
> Tom> Yes, oops.  I wonder how that slipped through.
> 
> Obviously I did not test in release mode.
> I've fixed the bug and tried it both ways.

Thanks Tom. Other than this comment, I had no other comment so,
now that it is fixed and tested, I think you can push.

-- 
Joel

Follow-Ups:
- Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode
  - From: Tom Tromey

References:
- [PATCH 0/2] two small configure patches
  - From: Tom Tromey
- [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode
  - From: Tom Tromey
- Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode
  - From: Joel Brobecker
- Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode
  - From: Tom Tromey
- Re: [PATCH 2/2] Do not pass -DNDEBUG to Python compilations in development mode
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]