This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Check for gmp when checking for mpfr

From: Joel Brobecker <brobecker at adacore dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 17 Sep 2018 11:18:03 -0700
Subject: Re: [PATCH 1/2] Check for gmp when checking for mpfr
References: <20180916184502.19617-1-tom@tromey.com> <20180916184502.19617-2-tom@tromey.com>

Hi Tom,

On Sun, Sep 16, 2018 at 12:45:01PM -0600, Tom Tromey wrote:
> There was a report on irc that the gdb check for mpfr failed when only
> static libraries are available.  The issue is that mpfr depends on
> gmp, but this is not handled explicitly by gdb.
> 
> Ideally upstream would switch to pkg-config.  Or even more ideally, we
> would incorporate pkg-config into the compiler and not mess with any
> of this.
> 
> Meanwhile, this changes gdb's configure to add gmp to the link line
> when checking for mpfr.
> 
> ChangeLog
> 2018-09-16  Tom Tromey  <tom@tromey.com>
> 
> 	* configure: Rebuild.
> 	* configure.ac: Use gmp as a library dependency when checking for
> 	mpfr.

Thanks for the patch. This looks good to me.

-- 
Joel

References:
- [PATCH 0/2] two small configure patches
  - From: Tom Tromey
- [PATCH 1/2] Check for gmp when checking for mpfr
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]