Re: [PATCH 1/2] Remove munmap_listp_free_cleanup

[Tom Tromey <tom at tromey dot com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Not a big deal, but we might as well use a vector.  The objects
Simon> are cheap to copy, so there's probably less overhead overall
Simon> (memory and time) to use a vector than a doubly linked list.

I made this change.

Simon> I was going to say:

Simon> 1. Why not use munmap_list as directly as field of setup_sections_data, instead
Simon>    of a unique_ptr, and
Simon> 2. std::move it to the compile_module object.

Simon> But that would require C++ifying compile_module and probably
Simon> do_module_cleanup too, and that's perhaps a too big of a step for
Simon> this patch.

Yeah, that's why I didn't do it.

Tom