This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sun, 16 Sep 2018 06:59:21 -0600
Subject: Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
References: <20180913053007.11780-1-tom@tromey.com> <20180913053007.11780-2-tom@tromey.com> <435d6db2-bbe9-7f79-3e3d-55ca8f2da0bc@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> +      gdbpy_ref<> pspace = pspace_to_pspace_object (obj->objfile->pspace);
>> +      return pspace.get ();
>> }

Simon> Can you double check this, shouldn't it be .release()?  Otherwise, LGTM.

Yes it should.  Whoops :(
I made this change.

Tom

References:
- [PATCH 0/4] Disallow the return of borrowed references
  - From: Tom Tromey
- [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
  - From: Tom Tromey
- Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]