This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] Use GNU style for metasyntactic variables in gdb

From: Simon Marchi <simark at simark dot ca>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sat, 15 Sep 2018 23:20:28 -0400
Subject: Re: [PATCH 2/3] Use GNU style for metasyntactic variables in gdb
References: <20180915025522.18723-1-tom@tromey.com> <20180915025522.18723-3-tom@tromey.com>

On 2018-09-14 10:55 p.m., Tom Tromey wrote:
> I searched for other spots that did not use the GNU style for
> metasyntactic syntactic variables.  This patch fixes most of the ones
> I found in gdb proper.  There are a few remaining in MI, but I was
> unsure whether those should be touched.

About MI, I don't see why it should be different.  Do you have specific
examples?

I stumbled on some messages like this:

  error (_("-environment-cd: Usage DIRECTORY"));

That looks confusing to me, I would much prefer

  error (_("Usage: -environment-cd DIRECTORY"));

Simon

Follow-Ups:
- Re: [PATCH 2/3] Use GNU style for metasyntactic variables in gdb
  - From: Tom Tromey
- Re: [PATCH 2/3] Use GNU style for metasyntactic variables in gdb
  - From: Tom Tromey

References:
- [PATCH 0/3] More use of GNU-style metasyntactic variables
  - From: Tom Tromey
- [PATCH 2/3] Use GNU style for metasyntactic variables in gdb
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]