This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] provide type_align gdbarch function for nios2
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, <qiyao at sourceware dot org>
- Date: Fri, 14 Sep 2018 19:47:19 -0600
- Subject: [patch] provide type_align gdbarch function for nios2
The attached patch fixes almost 400 failures in gdb.base/align.exp and
related tests due to a missing definition for the type_align hook for
nios2. I swiped the definition of the hook from the arc backend which
has similar conventions: the alignment of byte/halfword types matches
their size, but all types 4 bytes or larger are aligned on a 4-byte
boundary.
OK to commit?
-Sandra
commit e05f7a65e4cefcd706b79b07b3941a9c6130c01a
Author: Sandra Loosemore <sandra@codesourcery.com>
Date: Fri Sep 14 18:33:56 2018 -0700
Provide type_align gdbarch function for nios2.
2018-09-14 Sandra Loosemore <sandra@codesourcery.com>
gdb/
* nios2-tdep.c (nios2_type_align): New.
(nios2_gdb_arch_init): Install type_align hook.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4e667b7..6fe0526 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-09-14 Sandra Loosemore <sandra@codesourcery.com>
+
+ * nios2-tdep.c (nios2_type_align): New.
+ (nios2_gdb_arch_init): Install type_align hook.
+
2018-09-10 Andrew Burgess <andrew.burgess@embecosm.com>
* eval.c (fake_method::fake_method): Call xzalloc directly for a
diff --git a/gdb/nios2-tdep.c b/gdb/nios2-tdep.c
index c7d5b9f..eb5285a 100644
--- a/gdb/nios2-tdep.c
+++ b/gdb/nios2-tdep.c
@@ -2230,6 +2230,15 @@ nios2_get_longjmp_target (struct frame_info *frame, CORE_ADDR *pc)
return 1;
}
+/* Implement the type_align gdbarch function. */
+
+static ULONGEST
+nios2_type_align (struct gdbarch *gdbarch, struct type *type)
+{
+ type = check_typedef (type);
+ return std::min<ULONGEST> (4, TYPE_LENGTH (type));
+}
+
/* Initialize the Nios II gdbarch. */
static struct gdbarch *
@@ -2293,6 +2302,8 @@ nios2_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
set_gdbarch_float_bit (gdbarch, 32);
set_gdbarch_double_bit (gdbarch, 64);
+ set_gdbarch_type_align (gdbarch, nios2_type_align);
+
set_gdbarch_float_format (gdbarch, floatformats_ieee_single);
set_gdbarch_double_format (gdbarch, floatformats_ieee_double);