This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove variable in get_startup_shell non-static
- From: Tom Tromey <tom at tromey dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 14 Sep 2018 06:45:57 -0600
- Subject: Re: [PATCH] Remove variable in get_startup_shell non-static
- References: <20180913223416.12824-1-tom@tromey.com> <87k1npotux.fsf@redhat.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> IIRC this code was added by a patch of mine. I think your patch makes
Sergio> sense. Perhaps, since the SHELL can't change once you start GDB, this
Sergio> function could be made a bit smarter and check whether "ret" has been
Sergio> initialized or not (in order to call "getenv" just once), but really,
Sergio> that's not necessary at all, and your patch is totally fine.
Thanks, I'm going to check it in.
Tom