This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c

From: Sergio Durigan Junior <sergiodj at redhat dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: GDB Patches <gdb-patches at sourceware dot org>, Rich Felker <dalias at aerifal dot cx>, Romain Naour <romain dot naour at smile dot fr>, Thomas Petazzoni <thomas dot petazzoni at bootlin dot com>, Romain Naour <romain dot naour at gmail dot com>
Date: Wed, 12 Sep 2018 13:59:06 -0400
Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
References: <d588888e-dccc-50c8-5a6e-9c5c46a512cb@smile.fr> <20180912173113.2007-1-sergiodj@redhat.com> <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com>

On Wednesday, September 12 2018, Pedro Alves wrote:

> On 09/12/2018 06:31 PM, Sergio Durigan Junior wrote:
>
>> The most simple fix for this problem is to move 'is_regular_file' to
>> 'filestuff.c', which is not used by IPA.  This ends up making the
>> files more logically organized as well, since 'is_regular_file' is a
>> file operation.
>> 
>> No regressions found.
>> 
>> gdb/ChangeLog:
>> 2018-09-12  Sergio Durigan Junior  <sergiodj@redhat.com>
>> 
>> 	* common/common-utils.c: Don't include '<sys/stat.h>'.
>> 	(is_regular_file): Move to...
>> 	* common/filestuff.c (is_regular_file): ... here.
>> 	* common/common-utils.h (is_regular_file): Move to...
>> 	* common/filestuff.h (is_regular_file): ... here.
>
> OK.

Thanks, pushed.

3c025cfe5efc44eb4dfb03b53dca28e75096dd1e

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Follow-Ups:
- Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
  - From: Romain Naour

References:
- Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system
  - From: Romain Naour
- [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
  - From: Sergio Durigan Junior
- Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]