Re: [RFA] arm-pikeos: software single step

[Joel Brobecker <brobecker at adacore dot com>]

> Joel> The challenge is that, up to now, the PikeOS target was in all respects
> Joel> identical to a baremetal target as far as GDB was concerned, meaning
> Joel> we were using the baremetal osabi for this target too. This is no longer
> Joel> possible, and we need to introduce a new OSABI variant.
> 
> I don't really know anything about this area, but...
> 
> Is there any chance of introducing some flag into the object files so
> that the heuristic could be removed at some future point?

I don't really see this, because we don't really control the platform.

> Joel> +
> Joel> +static void
> Joel> +arm_pikeos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> 
> The usual thing about functions needing an intro comment.

OK, I will do that. I saw it, and grepped around, saw that it wasn't
really done for the few spot checks I did, so thought it was just
so obvious that it was deliberately omitted.

> Joel> +  { "Pikeos", NULL },
> 
> The email spelled it "PikeOS", so maybe it should read that way here as
> well.

Indeed, that's a good point.

Thanks for the review, Tom. New version of the patch coming up.
-- 
Joel