This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Logical short circuiting with argument lists
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Tom Tromey <tom at tromey dot com>, Richard Bunt <richard dot bunt at arm dot com>
- Cc: <gdb-patches at sourceware dot org>, <nd at arm dot com>
- Date: Sat, 8 Sep 2018 22:25:11 +0100
- Subject: Re: [PATCH v2] Logical short circuiting with argument lists
- References: <79494820-f795-ad3c-8546-0ad288cd05b0@arm.com> <87mustueua.fsf@tromey.com>
On 2018-09-07 11:23 PM, Tom Tromey wrote:
>>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:
>
> Thank you for the patch.
>
> Richard> koenig.exp was updated to include a testcase which exercises the
> Richard> modified skip logic in OP_VAR_VALUE, as it falls through from
> Richard> OP_ADL_FUNC.
>
> Nice, thanks.
>
> Richard> +void
> Richard> +skip_undetermined_arglist (int nargs, struct expression *exp, int *pos,
> Richard> + enum noside noside)
>
> This needs an introductory comment.
Also, you can get rid of the forward-declaration of skip_undetermined_arglist,
and the definition should be made static.
Simon