This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Fix ARI violations in c++compile
- From: Keith Seitz <keiths at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 30 Aug 2018 14:58:45 -0700
- Subject: [PATCH] Fix ARI violations in c++compile
This patch fixes two violations of the ARI (use of ATTRIBUTE_UNUSED and
"%ll").
gdb/ChangeLog
* compile/compile-cplus-types.c (compile_cplus_debug_output_1): Use
pulongest instead of "%lld".
* compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol): Remove
ATTRIBUTE_UNUSED.
---
gdb/ChangeLog | 7 +++++++
gdb/compile/compile-cplus-symbols.c | 2 +-
gdb/compile/compile-cplus-types.c | 4 ++--
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0d55fd45f5..7e62e8aa8c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+YYYY-MM-DD Keith Seitz <keiths@redhat.com>
+
+ * compile/compile-cplus-types.c (compile_cplus_debug_output_1): Use
+ pulongest instead of "%lld".
+ * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol): Remove
+ ATTRIBUTE_UNUSED.
+
2018-08-30 Andrew Burgess <andrew.burgess@embecosm.com>
* riscv-tdep.c (riscv_insn::decode): Decode c.addi4spn, c.sd,
diff --git a/gdb/compile/compile-cplus-symbols.c b/gdb/compile/compile-cplus-symbols.c
index 0f849fe365..234b97783b 100644
--- a/gdb/compile/compile-cplus-symbols.c
+++ b/gdb/compile/compile-cplus-symbols.c
@@ -335,7 +335,7 @@ convert_symbol_bmsym (compile_cplus_instance *instance,
void
gcc_cplus_convert_symbol (void *datum,
struct gcc_cp_context *gcc_context,
- enum gcc_cp_oracle_request request ATTRIBUTE_UNUSED,
+ enum gcc_cp_oracle_request request,
const char *identifier)
{
if (compile_debug)
diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c
index 7fc413606e..271cc665f8 100644
--- a/gdb/compile/compile-cplus-types.c
+++ b/gdb/compile/compile-cplus-types.c
@@ -1244,9 +1244,9 @@ compile_cplus_instance::gcc_cplus_leave_scope
gcc_decl. */
static void
-compile_cplus_debug_output_1 (gcc_type arg)
+compile_cplus_debug_output_1 (ULONGEST arg)
{
- fprintf_unfiltered (gdb_stdlog, "%lld", arg);
+ fprintf_unfiltered (gdb_stdlog, "%s", pulongest (arg));
}
static void
--
2.13.6