This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove some uses VEC from parsers

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: Tom Tromey <tom at tromey dot com>, <gdb-patches at sourceware dot org>
Date: Tue, 28 Aug 2018 11:35:05 -0600
Subject: Re: [PATCH] Remove some uses VEC from parsers
References: <20180827211901.20992-1-tom@tromey.com> <2a9d9432-3bd3-f4c7-0817-dbf6ad7d655d@ericsson.com>

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

>> else
>> {
>> -      VEC_safe_push (token_and_value, token_fifo, &next);
>> +      token_fifo.push_back (next);
>> }

Simon> Can you remove the extra braces, while at it?

Simon> LGTM, thanks!

I pushed it with this change.

Tom

References:
- [PATCH] Remove some uses VEC from parsers
  - From: Tom Tromey
- Re: [PATCH] Remove some uses VEC from parsers
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]