This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] Make target_options_to_string return an std::string
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 08 Aug 2018 09:11:58 -0600
- Subject: Re: [pushed] Make target_options_to_string return an std::string
- References: <20180808014216.30089-1-simon.marchi@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Return an std::string instead of a char *, saving some manual freeing.
Simon> I only manually tested with "set debug target 1" and "set debug lin-lwp
Simon> 1", since this only deals with debug output.
Simon> -/* Concatenate ELEM to LIST, a comma separate list, and return the
Simon> - result. The LIST incoming argument is released. */
Simon> +/* Concatenate ELEM to LIST, a comma separate list. */
I think this should read "comma-separated".
Other than that nit, this looks good to me.
Tom