This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 29 Jun 2018 13:21:58 +0100
- Subject: Re: [RFA_v3 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
- References: <20180624183708.888-1-philippe.waroquiers@skynet.be>
* Philippe Waroquiers <philippe.waroquiers@skynet.be> [2018-06-24 20:37:00 +0200]:
> This is the fourth iteration of the patch series that:
> * implements a new command
> 'frame apply [all | COUNT | -COUNT | id ID...] [FLAG]... COMMAND'.
I still have this patch pending (which I need to ping) but I still
hope to get it merged:
https://sourceware.org/ml/gdb-patches/2018-06/msg00170.html
This patch makes it much clearer (I think) that there are multiple was
to IDentify a frame, level, address, function-name.
I wonder if using the keyword 'id' might be confusing were my patch to
end up being merged? Would a consistent 'level' be better?
Interested to hear your thoughts...
Thanks,
Andrew
> * enhance 'thread apply COMMAND' by adding FLAG arguments.
> * adds some shortcuts commands.
> * documents the above in gdb.texinfo and NEWS.
> * adds a unit test for cli-utils.c.
> * adds test for 'frame apply'.
> * modify gdb.threads/pthreads.exp to test 'thread apply' FLAG arguments.
>
> The fourth version is RFA v3. It handles the comments given by Pedro.
> The main changes compared to RFA v2 are:
> * The -q (quiet) flag replaces the verbosity/-v/-q concept.
> * Addition of 'frame apply id ID... [FLAG]... COMMAND' to allow
> applying a command on a selected list of frames.
> * [FLAG]... arguments are now parsed iteratively.
> * Documentation and on-line help updated accordingly.
> * tests updated accordingly.
>
> The third version was RFA v2, handling the comments of Pedro about giving
> the flags individually.
> The changes compared to RFA v1 is:
> * The flags must be given individually, such as -v -v -c.
> * The documentation and on-line help was updated accordingly.
> * ChangeLog information is distributed in each commit log message.
>
> The second version was RFA v1, changes compared to RFC are:
> * Replied to all comments of Eli and Simon.
> * Tests and ChangeLog entries added.
> * Comments received from Pedro
>
> The first version was an RFC
> * Code and doc was complete, but was lacking ChangeLog and tests.
> * Comments received from Eli and Simon.
>
>
>
>
>