This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Fix Cell debugging regression (Re: [PATCH] Use thread_info and inferior pointers more throughout)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: palves at redhat dot com (Pedro Alves)
- Cc: tom at tromey dot com (Tom Tromey), gdb-patches at sourceware dot org
- Date: Wed, 27 Jun 2018 18:05:00 +0200 (CEST)
- Subject: Re: [PATCH v2] Fix Cell debugging regression (Re: [PATCH] Use thread_info and inferior pointers more throughout)
Pedro Alves wrote:
> Just OOC, I added a assertion like
> gdb_assert (lwpid == ph->thread->ptid.lwp ());
> and it didn't trigger on x86-64, I think because libthread_db
> on x86-64 uses ps_get_thread_area and doesn't call into these
> routines. Maybe it does in some cases, like core debugging.
> I didn't run the whole testsuite, only a couple threaded programs.
>
> Anyways, the assertion did fail on PowerPC.
OK, I see.
> gdb/ChangeLog:
> 2018-06-27 Pedro Alves <palves@redhat.com>
>
> * proc-service.c (get_ps_regcache): New.
> (ps_lgetregs, ps_lsetregs, ps_lgetfpregs)
> (ps_lsetfpregs): Use it.
This looks good to me. Thanks!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com