This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 09/10] Ptrace support for AArch64 SVE gdbsever

From: Simon Marchi <simark at simark dot ca>
To: Alan Hayward <alan dot hayward at arm dot com>, gdb-patches at sourceware dot org
Cc: nd at arm dot com
Date: Sun, 10 Jun 2018 22:43:05 -0400
Subject: Re: [PATCH v2 09/10] Ptrace support for AArch64 SVE gdbsever
References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-10-alan.hayward@arm.com>

On 2018-06-06 11:16 AM, Alan Hayward wrote:
> Add checks to detect SVE tdesc. Easiest way to do this is by checking the
> size of the vector registers.
> 
> Use the common aarch64 ptrace copy functions for reading/writing registers.
> A wrapper is required due to the common functions using reg_buffer_common.

Hi Alan,

There are macros not defined in the headers adde in patch 2/10, so I get this since
I build against the headers of an older kernel:

  CXX    linux-aarch64-low.o
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-low.c:559:38: error: 'SVE_PT_REGS_SVE' was not declared in this scope
     SVE_PT_SIZE (AARCH64_MAX_SVE_VQ, SVE_PT_REGS_SVE), EXTENDED_REGS,
                                      ^~~~~~~~~~~~~~~
/home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-low.c:559:53: error: 'SVE_PT_SIZE' was not declared in this scope
     SVE_PT_SIZE (AARCH64_MAX_SVE_VQ, SVE_PT_REGS_SVE), EXTENDED_REGS,

If we decide not to include the Linux kernel header replacements in the GDB tree,
it's not an issue.

Simon

References:
- [PATCH v2 00/10] gdb/gdbserver support for aarch64 SVE
  - From: Alan Hayward
- [PATCH v2 09/10] Ptrace support for AArch64 SVE gdbsever
  - From: Alan Hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]