This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA v3 1/6] Remove dead code in end_psymtab
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Thu, 7 Jun 2018 10:19:50 -0600
- Subject: [RFA v3 1/6] Remove dead code in end_psymtab
- References: <20180607161955.9800-1-tom@tromey.com>
I noticed that there is a bit of dead code in end_psymtab.
This deletes it.
Normally I would investigate a fix for the code. However, considering
that the code has been this way a long time (since the first import to
sourceware) and considering that dbxread.c is not as important any
more, I think it's safe to just consider that there's no bug.
gdb/ChangeLog
2018-06-07 Tom Tromey <tromey@redhat.com>
* dbxread.c (end_psymtab): Remove dead code.
---
gdb/ChangeLog | 4 ++++
gdb/dbxread.c | 8 +-------
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 1b524ec0e22..4092d1cab74 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -2045,13 +2045,7 @@ dbx_end_psymtab (struct objfile *objfile, struct partial_symtab *pst,
ALL_OBJFILE_PSYMTABS (objfile, p1)
{
if (p1->texthigh == 0 && p1->textlow != 0 && p1 != pst)
- {
- p1->texthigh = pst->textlow;
- /* If this file has only data, then make textlow match
- texthigh. */
- if (p1->textlow == 0)
- p1->textlow = p1->texthigh;
- }
+ p1->texthigh = pst->textlow;
}
}
--
2.13.6