This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed+RFC] C++ exception during command triggers stale cleanup internal-warning
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Tue, 22 May 2018 10:39:36 -0400
- Subject: [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning
- References: <f9d45c1b-4738-2220-6690-8b80ae10da98@simark.ca>
Hello,
There was a small bug in Tom's patch that caused the execution
of the "catch assert" command to throw a C++ exception. I have
pushed the following patch to master as an obvious fix to the
immediate issue:
[] fix "stale cleanup" internal-warning when using "catch assert"
But at the same time, this leads me to believe we may have a weakness
top.c::execute_command, which installs a cleanup, and "forgets" to
discard it when C++ exceptions are raised.
But maybe that's just the way it is, and we just want to make sure
we never let C+ exceptions get away from us? Thoughts on that?
Anyways, for now, the immediate issue is fixed.
--
Joel