Re: New ARI warning Fri May 18 01:56:48 UTC 2018

[Joel Brobecker <brobecker at adacore dot com>]

> > You can tag them as OK with a /* ARI: ... */ comment.
> > 
> > But I suspect we just want to exclude files in gdb/unittests instead?
> > Here is a patch that does that. Tested by checking the change in
> > output before and after:
> > 
> >     1101,1120d1100
> >     < ./unittests/array-view-selftests.c
> >     < ./unittests/common-utils-selftests.c
> >     < ./unittests/environ-selftests.c
> >     < ./unittests/function-view-selftests.c
> >     < ./unittests/lookup_name_info-selftests.c
> >     < ./unittests/memory-map-selftests.c
> >     < ./unittests/memrange-selftests.c
> >     < ./unittests/observable-selftests.c
> >     < ./unittests/offset-type-selftests.c
> >     < ./unittests/optional-selftests.c
> >     < ./unittests/ptid-selftests.c
> >     < ./unittests/rsp-low-selftests.c
> >     < ./unittests/scoped_fd-selftests.c
> >     < ./unittests/scoped_mmap-selftests.c
> >     < ./unittests/scoped_restore-selftests.c
> >     < ./unittests/string_view-selftests.c
> >     < ./unittests/tracepoint-selftests.c
> >     < ./unittests/unpack-selftests.c
> >     < ./unittests/utils-selftests.c
> >     < ./unittests/xml-utils-selftests.c
> > 
> > gdb/ChangeLog:
> > 
> >         * contrib/ari/gdb_find.sh: Exclude the unittest directory.
> 
> I don't really mind, maybe some rules related to formatting would still be
> appropriate for unittests/.

Right, which is why I formulated this as a question. I don't really
know what style we want there. But since it was easy to patch the
script, I thought I'd send that right away, to show one of the options.
But I'd be OK with deciding that unittests/ should follow the GDB
coding standards.

> Is is possible to exclude unittests/* instead of listing all the
> files?  We'll surely add new files in there, and don't want to have to
> update that script every time.

This is exactly what the patch I sent does. The above was just
the diff of output between before and after patch (sorry for
the cryptic message).

     find "$@" \
         -name testsuite -prune -o \
    +    -name unittests -prune -o \
         -name gdbserver -prune -o \
         -name gdbtk -prune -o \
         -name gnulib -prune -o \

-- 
Joel