This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 8/8] [PowerPC] Recognize isa205 in linux core files
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: pedromfc at linux dot vnet dot ibm dot com (Pedro Franco de Carvalho)
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 17 May 2018 10:22:39 +0200 (CEST)
- Subject: Re: [PATCH 8/8] [PowerPC] Recognize isa205 in linux core files
Pedro Franco de Carvalho wrote:
> Ulrich Weigand <uweigand@de.ibm.com> writes:
>
> > Maybe this routine should now be moved to ppc-linux-tdep.c ...
> >
> >> + CORE_ADDR hwcap = 0;
> >> +
> >> + target_auxv_search (target, AT_HWCAP, &hwcap);
> >> +
> >> + features.isa205 = ppc_linux_has_isa205 (hwcap);
> >
> > ... so it can be reused here?
> >
> > Otherwise this looks OK to me.
>
> Should the routine take a struct target_ops * parameter, so that
> core_read_description can pass its target (for calling
> target_auxv_search)? In this case all the calls in ppc_linux_nat.c would
> also have to be updated.
Right, I guess that makes sense.
(Another question is why ppp-linux-nat.c repeats this call all the
time, maybe it would be better to cache the result per inferior ...
But that's certainly a separate issue.)
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com