Re: [PATCH 4 PR gdb/16959] gdb hangs in infinite recursion

[Weimin Pan <weimin dot pan at oracle dot com>]

On 3/26/2018 8:28 PM, Simon Marchi wrote:
> On 2018-03-26 17:54, Weimin Pan wrote:
> > @@ -658,15 +659,14 @@ cp_print_static_field (struct type *type,
> >        addr = value_address (val);
> >        obstack_grow (&dont_print_statmem_obstack, (char *) &addr,
> >              sizeof (CORE_ADDR));
> > -      type = check_typedef (type);
> > -      cp_print_value_fields (type, value_enclosing_type (val),
> > +      cp_print_value_fields (real_type, value_enclosing_type (val),
>
> As discussed previously, here we should pass the original type.

Hi Simon,

OK, just made the change to pass the original type to 
cp_print_value_fields()
which in turn calls check_typedef() to get the real type.

> Btw, if you now have push access to the git repo, you should add 
> yourself in the "Write After Approval" section of the gdb/MAINTAINERS 
> file.  This will help you make sure everything is set up correctly.  
> Don't forget to include a ChangeLog entry for it and post the patch on 
> the mailing list afterwards (mentioning that you have pushed it), you 
> can inspire yourself from how people have done it in the past.

Is there any document or instructions that I can access to understand 
the whole process better?

Thanks,
Weimin

> Simon