This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 2018-03-24 14:54, Wei-min Pan wrote:
Please note the check_typedef() call (now redundant and removed) before calling cp_print_value_fields(). So passing the resolved type is correct.
I think it's better if functions don't assume too much what other functions need (original type vs real type). cp_print_value_fields may not require the real type today, but maybe that will change one day, and that call will have to be changed (if we even notice it). So in that sense, it's better to always pass down the original type and let functions get the real type for their own use if they need it.
Simon
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |