This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v4 05/10] Commonise tdesc types

From: Simon Marchi <simon dot marchi at ericsson dot com>
To: <alan dot hayward at arm dot com>, <gdb-patches at sourceware dot org>
Cc: <nd at arm dot com>
Date: Fri, 23 Mar 2018 16:12:26 -0400
Subject: Re: [PATCH v4 05/10] Commonise tdesc types
References: <20180322084429.26250-1-alan.hayward@arm.com> <20180322084429.26250-6-alan.hayward@arm.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

On 2018-03-22 04:44 AM, alan.hayward@arm.com wrote:
> From: Alan Hayward <alan.hayward@arm.com>
> 
> This patch moves all the various tdesc types to common code.
> 
> It also commonises all the tdesc_ functions that are stubbed
> out in gdbserver.
> 
> This is a lot of code to move across, but it is the simplest
> way of getting gdbserver to retain the target description
> information.
> 
> With this patch, gdb and gdbserver will now parse a target
> description in the same way.
> 
> Identical to V3 version.
> 
> Alan.

Just a nit, some functions in common/tdesc.c have the

  /* See common/tdesc.h.  */

comment, and some don't.

Simon

References:
- [PATCH v4 00/10] Remove gdbserver dependency on xml files
  - From: alan . hayward
- [PATCH v4 05/10] Commonise tdesc types
  - From: alan . hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]