This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] mips: set significant_addr_bit to number of bits in CORE_ADDR
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: Vlad Ivanov <vlad dot ivanov at lab-systems dot ru>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 19 Mar 2018 14:11:13 +0000
- Subject: Re: [PATCH] mips: set significant_addr_bit to number of bits in CORE_ADDR
- References: <20180315143855.17941-1-vlad.ivanov@lab-systems.ru>
On Thu, 15 Mar 2018, Vlad Ivanov wrote:
> MIPS targets use signed PC values. Since commit a0de8c21
> single-stepping on these targets didn't work due to the addition of
> address_significant in adjust_breakpoint_address - sign bits were cut
> off because of default value of significant_addr_bit. With this
> commit, significant_addr_bit in gdbarch is set to the number of bits
> in CORE_ADDR so breakpoint address comparison works again for MIPS
> targets.
NAK. As noted in the other thread I think it's the default that has to
be fixed instead.
Maciej