This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] remote-stdio-gdbserver: Pass "target" to remote_exec to delete file
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Tue, 6 Mar 2018 10:54:11 -0500
- Subject: [PATCH] remote-stdio-gdbserver: Pass "target" to remote_exec to delete file
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
As described here
https://sourceware.org/bugzilla/show_bug.cgi?id=22841
there seems to be situations where the remote-stdio-gdbserver board
fails to delete the uploaded binary file. Passing "target" fixes the
issue for Christian who reported the bug.
I did not experience this problem, but passing "target" to remote_exec
still works for me, so I'm fine with changing it.
Any objection?
gdb/testsuite/ChangeLog:
* boards/remote-stdio-gdbserver.exp (${board}_file): Pass
"target" to remote_exec.
---
gdb/testsuite/boards/remote-stdio-gdbserver.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/boards/remote-stdio-gdbserver.exp b/gdb/testsuite/boards/remote-stdio-gdbserver.exp
index aff7902..d559b85 100644
--- a/gdb/testsuite/boards/remote-stdio-gdbserver.exp
+++ b/gdb/testsuite/boards/remote-stdio-gdbserver.exp
@@ -75,7 +75,7 @@ proc get_target_remote_pipe_cmd { } {
proc ${board}_file { dest op args } {
if { $op == "delete" } {
- return [remote_exec [get_remote_login] "rm -f $args"]
+ return [remote_exec target "rm -f $args"]
}
return [eval [list standard_file $dest $op] $args]
}
--
2.7.4